MantisBT - Hall D Offline | |||||
| View Issue Details | |||||
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0000429 | Hall D Offline | General | public | 2014-12-03 16:10 | 2014-12-04 08:01 |
| Reporter | shepherd | ||||
| Assigned To | davidl | ||||
| Priority | low | Severity | minor | Reproducibility | always |
| Status | resolved | Resolution | fixed | ||
| Platform | OS | OS Version | |||
| Summary | 0000429: type mismatch | ||||
| Description | I notice there is some type mismatch between the Df250PulseIntegral class and, say, the DFCALDigiHit class. (It probably exists in other DigiHit classes also.) In DTranslationTable.h class there is this template: template<class T> void DTranslationTable::CopyDf250Info(T *h, const Df250PulseIntegral *pi, const Df250PulseTime *pt, const Df250PulsePedestal *pp) const { /// Copy info from the fADC250 into a hit object. h->pulse_integral = pi->integral; For the last assignment the RHS is of type int32_t, while the LHS is of type uint32_t. It turns out the RHS is initialized from data of type uint32_t in the constructor of the Df250PulseIntegral object. Therefore, I *think* this is harmless, but it would be good to correct it for consistency. | ||||
| Steps To Reproduce | |||||
| Additional Information | |||||
| Tags | No tags attached. | ||||
| Relationships | |||||
| Attached Files | |||||
| Issue History | |||||
| Date Modified | Username | Field | Change | ||
| 2014-12-03 16:10 | shepherd | New Issue | |||
| 2014-12-04 08:01 | davidl | Note Added: 0000621 | |||
| 2014-12-04 08:01 | davidl | Status | new => resolved | ||
| 2014-12-04 08:01 | davidl | Resolution | open => fixed | ||
| 2014-12-04 08:01 | davidl | Assigned To | => davidl | ||
| Notes | |||||
|
|
|||||
|
|
||||