Difference between revisions of "Π polarizability Software Meeting Feb 3, 2022"

From GlueXWiki
Jump to: navigation, search
(Created page with "== Meeting Time And Location == 09:30 EST (JLab time) Weekly Meeting <br> REMOTE during Covid-19 ==Connecting== <div class="toccolours mw-collapsible mw-collapsed"> Join Zoo...")
 
 
(3 intermediate revisions by the same user not shown)
Line 1: Line 1:
 
== Meeting Time And Location ==
 
== Meeting Time And Location ==
09:30 EST (JLab time) Weekly Meeting <br>
+
12:30 EST (JLab time) Thursdays Weekly Meeting <br>
 
+
REMOTE during Covid-19
+
  
 
==Connecting==
 
==Connecting==
Line 49: Line 47:
  
 
== Agenda  ==
 
== Agenda  ==
# Pending Pull Requests and Reviews
+
# Meeting format
 
+
#:
# Discussion of status and roadmap
+
# [https://github.com/JeffersonLab/halld_recon/tree/CPP Pending Pull Requests and Reviews] (CPP branch)
#* Tracking, FMWPC, PID, Monitoring, Calibration
+
#:
#** PID:
+
# [https://github.com/JeffersonLab/halld_recon/tree/CPP/src/libraries/FMWPC FMWPC Library]
#*** e+e- PID
+
#* DFMWPCHit - Calibrated hits
#*** &pi;+&pi;- PID
+
#* DFMWPCCluster
#*** &pi;&mu; classification
+
#* DFMWPCMatchedTrack
 +
#:
 +
# PID:
 +
#* e+e- PID
 +
#* &pi;+&pi;- PID
 +
#* &pi;&mu; classification
 +
#:
 +
# Event viewer
 +
#:
 +
# FMWPC_online monitoring plugin
 
#:
 
#:
 
# CPP Simulations
 
# CPP Simulations
# Other business
+
#:
# Next meeting
+
# AOT
  
 
== Useful Links ==
 
== Useful Links ==
* [https://github.com/JeffersonLab/halld_recon/tree/CPP GitHub CPP branch of halld_recon]
 
  
 
== Minutes ==
 
== Minutes ==
Attendees: David L., Mark I., Simon T., Andrew S., Albert F., Nikhil K., Elton S.
 
  
# Tracking
+
* Pending Pull Requests
#* Extrapolations to FMWPC complete (Simon)
+
** Simon merged the pending PR for the CPP branch
#* Other modifications to tracking to support CPP are completed. We are unaware of any other modifications that will be needed.
+
** Elton still has an outstanding PR from Nov. 10, 2021 for 2pi Primakoff. David will ping him on whether it should still be merged.
#:
+
*:
# FMWPC reconstruction
+
* FMWPC library
#* Some code in place that Sean apparently copied from CDC. Needs to be followed up on and items created in CCDB.
+
** DFMWPCHit - Simon noted that ''dE'' is out of place and ''q'' is a more appropriate variable. He will make the change. Alex is also noted as the original creator of the class and will continue as contact person for it.
#* Some discussion over the [https://docs.google.com/presentation/d/1HkMlIgEzZaNuDpH__7YXINmNYZvc78gLoMUoosmbWjs/edit?usp=sharing options David showed at the CPP meeting earlier in the week]
+
**:
#* May need to pursue both as some work has been done on each option already and it is unclear which will be the best.
+
** Raw mode - We discussed the possibility of processing the waveform data following the discussion of the previous day's CPP meeting. Decision was to keep working with the compressed mode format for now.
# CTOF - (scintillator behind FMWPC)
+
**:
#* Simon has implemented as classes in FMWPC library
+
** DFMWPCCluster
#:
+
*** Alex created this based on the FDC cathode clustering algorithm.
# FCAL
+
*** Code allows for single hit clusters (as would be common, esp. for muons)
#* Simon has added track matched single block hits that are not associated with any shower to the REST file format.
+
*** Code has been tested with both test stand data and simulated event data
#* This allows analysis of these hits which may be due to MIP particles later.
+
*** Clusters are currently formed in local coordinate system (e.g. wire position and wire number without respect for rotation of the wire plane in the lab coordinate system). Needs translation into global(lab) coordinate system.
#:
+
*** Time cuts are very loose at the moment and will be tightened later when appropriate values are obtained.
# Pending Pull Request
+
**:
#* Mark had noted that there is a pending PR on GitHub for the CPP branch where many changes have been made. Recent changes David committed to the branch are now automatically added to the PR
+
*** DFMWPCMatchedTrack - Currently has its own built-in FMWPC cluster finder that is independent of the DFMWPCCluster objects. David will modify to use the DFMWPCCluster class. This will require adding ''first_wire'' and ''last_wire'' data members to it.
#* Some review items had been entered by Sean and Simon has already address.
+
*:
#* Mark contacted Sean during the meeting to check if he was satisfied with all of the changes. He responded during the meeting that he was OK for the PR to proceed.
+
* e+e- classification factory
#* Some further delay to make sure recent changes David entered since then are OK. (I cannot recall who, if anyone, volunteered to actually accept the PR).
+
** Andrew began work on creating a JANA factory for this. Some technical questions on integrating with FMWPC library as opposed to plugin were addressed.
#:
+
** Weights for the TMVA model will be needed by the factory. These should be placed in a similar location as the ones for the FCAL hadronic classifier. Likely as a ''JANA resource''.
# Monitoring
+
 
#* Elton noted that the current FMWPC_online plugin does not produce anything for simulated data
+
=== Action Items ===
#* This is due to it being a skeleton set up to only look at DFMWPCDigiHit objects where are not present in MC data.
+
# Contact Elton about outstanding PR (David)
#* David volunteered to add some histograms for the calibrated hits (DFMWPCHit) so it can be used for MC data as well. This will also be needed for monitoring during the full experiment.
+
# Remove dE and fill in q for DFMWPCHit (Simon)
#:
+
# Add conversion to lab coordinates in DFMWPCCluster (Alex)
# e+e- PID
+
# Add ''first_wire'' and ''last_wire'' to DFMWPCCluster (David)
#* Some discussion over adding e+e- code that can be used to identify e+e- events using some of the machinery Andrew has developed.
+
# Replace FMWPC clusterizer in DFMWPCMatchedTrack with DFMWPCCluster objects (David)
#* Not clear whether it should be implemented as a JANA factory or in something downstream of DReactionFilter. Andrew will look and consider.
+
# Identify were weights for e+e- model should be stored for general access (Andrew)
#:
+
# Next Meeting
+
#* David will set up a Doodle poll to identify a weekly meeting time. This may drop to Bi-weekly after we get more momentum.
+

Latest revision as of 11:27, 7 February 2022

Meeting Time And Location

12:30 EST (JLab time) Thursdays Weekly Meeting

Connecting

Join ZoomGov Meeting
https://jlab-org.zoomgov.com/j/1613177947?pwd=MUtiRnZjWnF4SzFjL0NwRW83NC9uZz09
Meeting ID: 161 317 7947
Passcode: 287835

David Lawrence is inviting you to a scheduled ZoomGov meeting.

Topic: CPP Software Meeting
Time: This is a recurring meeting Meet anytime

Join ZoomGov Meeting
https://jlab-org.zoomgov.com/j/1613177947?pwd=MUtiRnZjWnF4SzFjL0NwRW83NC9uZz09

Meeting ID: 161 317 7947
Passcode: 287835
One tap mobile
+16692545252,,1608628791# US (San Jose)
+16468287666,,1608628791# US (New York)

Dial by your location
       +1 669 254 5252 US (San Jose)
       +1 646 828 7666 US (New York)
       +1 669 216 1590 US (San Jose)
       +1 551 285 1373 US
       833 568 8864 US Toll-free
Meeting ID: 161 317 7947
Find your local number: https://jlab-org.zoomgov.com/u/acZK7hDWFf
 
Join by SIP
1608628791@sip.zoomgov.com

Join by H.323
161.199.138.10 (US West)
161.199.136.10 (US East)
Meeting ID: 160 862 8791
Passcode: 112160


Agenda

  1. Meeting format
  2. Pending Pull Requests and Reviews (CPP branch)
  3. FMWPC Library
    • DFMWPCHit - Calibrated hits
    • DFMWPCCluster
    • DFMWPCMatchedTrack
  4. PID:
    • e+e- PID
    • π+π- PID
    • πμ classification
  5. Event viewer
  6. FMWPC_online monitoring plugin
  7. CPP Simulations
  8. AOT

Useful Links

Minutes

  • Pending Pull Requests
    • Simon merged the pending PR for the CPP branch
    • Elton still has an outstanding PR from Nov. 10, 2021 for 2pi Primakoff. David will ping him on whether it should still be merged.
  • FMWPC library
    • DFMWPCHit - Simon noted that dE is out of place and q is a more appropriate variable. He will make the change. Alex is also noted as the original creator of the class and will continue as contact person for it.
    • Raw mode - We discussed the possibility of processing the waveform data following the discussion of the previous day's CPP meeting. Decision was to keep working with the compressed mode format for now.
    • DFMWPCCluster
      • Alex created this based on the FDC cathode clustering algorithm.
      • Code allows for single hit clusters (as would be common, esp. for muons)
      • Code has been tested with both test stand data and simulated event data
      • Clusters are currently formed in local coordinate system (e.g. wire position and wire number without respect for rotation of the wire plane in the lab coordinate system). Needs translation into global(lab) coordinate system.
      • Time cuts are very loose at the moment and will be tightened later when appropriate values are obtained.
      • DFMWPCMatchedTrack - Currently has its own built-in FMWPC cluster finder that is independent of the DFMWPCCluster objects. David will modify to use the DFMWPCCluster class. This will require adding first_wire and last_wire data members to it.
  • e+e- classification factory
    • Andrew began work on creating a JANA factory for this. Some technical questions on integrating with FMWPC library as opposed to plugin were addressed.
    • Weights for the TMVA model will be needed by the factory. These should be placed in a similar location as the ones for the FCAL hadronic classifier. Likely as a JANA resource.

Action Items

  1. Contact Elton about outstanding PR (David)
  2. Remove dE and fill in q for DFMWPCHit (Simon)
  3. Add conversion to lab coordinates in DFMWPCCluster (Alex)
  4. Add first_wire and last_wire to DFMWPCCluster (David)
  5. Replace FMWPC clusterizer in DFMWPCMatchedTrack with DFMWPCCluster objects (David)
  6. Identify were weights for e+e- model should be stored for general access (Andrew)