0000271: Factories from plugins not given priority

View Issue Details [ Jump to Notes ]

[ Issue History ] [ Print ]

Project

Category

View Status

Date Submitted

Last Update

0000271

JANA

Bug

public

2012-07-12 10:10

2012-08-15 15:59

Reporter

davidl

Assigned To

davidl

Priority

normal

Severity

minor

Reproducibility

always

Status

resolved

Resolution

fixed

Platform

OS Version

Summary

0000271: Factories from plugins not given priority

Description

Contrary to the advertised functionality, factories added via plugins are not used in preference to ones statically compiled into an executable. The apparent behavior is:

Run() ->
DApplication::Init() ->
AttachPlugins()

The factory generator in DANA is created and added in the DApplication constructor. Any created in a plugin are added later through the above calling sequence. The factory generators are called in order so any coming from plugins are called last. Therefore, factories from plugins are added to the bottom of the list for each JEventLoop.

To fix this, one would need to do the following in AttachPlugins:
- make a temporary copy of the factory generator pointers
- clear the list of factory generator pointers
- call InitPlugin for all plugins
- append the list of factory generator pointers from the temporary copy

This would also mean the factories from generators have priority in the order that the plugins are specified.

Tags

No tags attached.

Attached Files

Relationships

Notes
(0000427) davidl (administrator) 2012-08-15 15:59	The change was implemented as described in the issue description. Testing was tedious though since it turns out that using the same name for the factory generator class in the plugin as was used in the executable caused the GenerateFactories() method of the statically linked class to be used. This effectively makes two sets of statically linked factories and no sets of the plugin factories.

Issue History
Date Modified	Username	Field	Change
2012-07-12 10:10	davidl	New Issue
2012-08-15 15:59	davidl	Note Added: 0000427
2012-08-15 15:59	davidl	Status	new => resolved
2012-08-15 15:59	davidl	Resolution	open => fixed
2012-08-15 15:59	davidl	Assigned To	=> davidl